error handling in challenge

CMakeLists.txt

@@ -43,12 +43,14 @@ add_executable(xbot
   main.cpp
   irc_commands.inc
   bot.cpp
+  challenge.cpp
+  client.cpp
   connection.cpp
   irc_coroutine.cpp
   ircmsg.cpp
+  openssl_errors.cpp
   registration.cpp
   sasl_mechanism.cpp
-  client.cpp
   settings.cpp
   snote.cpp
 )

connection.cpp

@@ -224,13 +224,19 @@ auto Connection::send_join(std::string_view channel) -> void
     write_irc("JOIN", channel);
 }
 
-auto Connection::send_whois(std::string_view arg1, std::string_view arg2) -> void
+auto Connection::send_challenge(std::string_view message) -> void
 {
-    if (arg2.empty()) {
+    write_irc("CHALLENGE", message);
-        write_irc("WHOIS", arg1);
+}
-    } else {
+
-        write_irc("WHOIS", arg1, arg2);
+auto Connection::send_whois(std::string_view arg1) -> void
-    }
+{
+    write_irc("WHOIS", arg1);
+}
+
+auto Connection::send_whois_remote(std::string_view arg1, std::string_view arg2) -> void
+{
+    write_irc("WHOIS", arg1, arg2);
 }
 
 auto Connection::on_authenticate(const std::string_view chunk) -> void

connection.hpp

@@ -2,6 +2,7 @@
 
 #include "irc_command.hpp"
 #include "ircmsg.hpp"
+#include "ref.hpp"
 #include "snote.hpp"
 #include "stream.hpp"
 
@@ -12,21 +13,8 @@
 #include <memory>
 #include <string>
 
-template <typename T, int(*UpRef)(T*), void(*Free)(T*)>
-class Ref {
-    struct Deleter { auto operator()(auto ptr) { Free(ptr); }};
-    std::unique_ptr<T, Deleter> obj;
-public:
-    Ref() = default;
-    Ref(T* t) : obj{t} { if (t) UpRef(t); }
-    auto get() const -> T* { return obj.get(); }
-};
-
 struct ConnectSettings
 {
-    using X509_Ref = Ref<X509, X509_up_ref, X509_free>;
-    using EVP_PKEY_Ref = Ref<EVP_PKEY, EVP_PKEY_up_ref, EVP_PKEY_free>;
-
     bool tls;
     std::string host;
     std::uint16_t port;
@@ -107,7 +95,9 @@ public:
     auto send_authenticate(std::string_view message) -> void;
     auto send_authenticate_encoded(std::string_view message) -> void;
     auto send_authenticate_abort() -> void;
-    auto send_whois(std::string_view, std::string_view = {}) -> void;
+    auto send_whois(std::string_view) -> void;
+    auto send_whois_remote(std::string_view, std::string_view) -> void;
+    auto send_challenge(std::string_view) -> void;
 
 };
 

main.cpp

@@ -1,14 +1,15 @@
 #include "bot.hpp"
 #include "c_callback.hpp"
+#include "challenge.hpp"
 #include "client.hpp"
 #include "connection.hpp"
+#include "openssl_errors.hpp"
 #include "registration.hpp"
 #include "settings.hpp"
 
 #include <boost/asio.hpp>
 #include <boost/log/trivial.hpp>
 
-#include <openssl/err.h>
 #include <openssl/pem.h>
 
 #include <cstdio>
@@ -18,21 +19,12 @@
 
 using namespace std::literals;
 
-static auto log_openssl_errors(const std::string_view prefix) -> void
+static auto cert_from_file(const std::string &filename) -> X509_Ref
 {
-    auto err_cb = [prefix](const char *str, size_t len) -> int {
+    X509_Ref cert;
-        BOOST_LOG_TRIVIAL(error) << prefix << std::string_view{str, len};
-        return 0;
-    };
-    ERR_print_errors_cb(CCallback<decltype(err_cb)>::invoke, &err_cb);
-}
-
-static auto cert_from_file(const std::string &filename) -> ConnectSettings::X509_Ref
-{
-    ConnectSettings::X509_Ref cert;
     if (const auto fp = fopen(filename.c_str(), "r"))
     {
-        cert = PEM_read_X509(fp, nullptr, nullptr, nullptr);
+        cert.reset(PEM_read_X509(fp, nullptr, nullptr, nullptr));
         if (cert.get() == nullptr)
         {
             log_openssl_errors("Reading certificate: "sv);
@@ -47,12 +39,18 @@ static auto cert_from_file(const std::string &filename) -> ConnectSettings::X509
     return cert;
 }
 
-static auto key_from_file(const std::string &filename) -> ConnectSettings::EVP_PKEY_Ref
+static auto key_from_file(const std::string &filename, const std::string_view password) -> EVP_PKEY_Ref
 {
-    ConnectSettings::EVP_PKEY_Ref key;
+    EVP_PKEY_Ref key;
     if (const auto fp = fopen(filename.c_str(), "r"))
     {
-        key = PEM_read_PrivateKey(fp, nullptr, nullptr, nullptr);
+        auto cb = [password](char * const buf, int const size, int) -> int {
+            if (size < password.size()) { return -1; }
+            std::copy(password.begin(), password.end(), buf);
+            return password.size();
+        };
+
+        key.reset(PEM_read_PrivateKey(fp, nullptr, CCallback<decltype(cb)>::invoke, &cb));
         if (key.get() == nullptr)
         {
             log_openssl_errors("Reading private key: "sv);
@@ -69,16 +67,16 @@ static auto key_from_file(const std::string &filename) -> ConnectSettings::EVP_P
 
 static auto start(boost::asio::io_context &io, const Settings &settings) -> void
 {
-    ConnectSettings::X509_Ref cert;
+    X509_Ref cert;
     if (settings.use_tls && not settings.tls_certfile.empty())
     {
         cert = cert_from_file(settings.tls_certfile);
     }
 
-    ConnectSettings::EVP_PKEY_Ref key;
+    EVP_PKEY_Ref key;
     if (settings.use_tls && not settings.tls_keyfile.empty())
     {
-        key = key_from_file(settings.tls_keyfile);
+        key = key_from_file(settings.tls_keyfile, "");
     }
 
     const auto connection = std::make_shared<Connection>(io);
@@ -96,9 +94,15 @@ static auto start(boost::asio::io_context &io, const Settings &settings) -> void
         }
     });
 */
-    client->sig_registered.connect([connection, client]() {
+    client->sig_registered.connect([&settings, connection, client]() {
         connection->send_join("##glguy"sv);
         connection->send_whois(client->get_my_nick());
+
+        if (not settings.challenge_username.empty() &&
+            not settings.challenge_key_file.empty()) {
+            auto key = key_from_file(settings.challenge_key_file, settings.challenge_key_password);
+            Challenge::start(*connection, settings.challenge_username, std::move(key));
+        }
     });
 
     connection->sig_disconnect.connect(

openssl_errors.cpp

@@ -0,0 +1,14 @@
+#include "openssl_errors.hpp"
+
+#include "c_callback.hpp"
+
+#include <boost/log/trivial.hpp>
+
+auto log_openssl_errors(const std::string_view prefix) -> void
+{
+    auto err_cb = [prefix](const char *str, size_t len) -> int {
+        BOOST_LOG_TRIVIAL(error) << prefix << std::string_view{str, len};
+        return 0;
+    };
+    ERR_print_errors_cb(CCallback<decltype(err_cb)>::invoke, &err_cb);
+}

settings.cpp

@@ -20,6 +20,9 @@ auto Settings::from_stream(std::istream &in) -> Settings
         .tls_hostname = config["tls_hostname"].value_or(std::string{}),
         .tls_certfile = config["tls_certfile"].value_or(std::string{}),
         .tls_keyfile = config["tls_keyfile"].value_or(std::string{}),
+        . challenge_username = config["challenge_username"].value_or(std::string{}),
+        . challenge_key_file = config["challenge_key_file"].value_or(std::string{}),
+        . challenge_key_password = config["challenge_key_password"].value_or(std::string{}),
         .use_tls = config["use_tls"].value_or(false),
     };
 }

settings.hpp

@@ -21,6 +21,10 @@ struct Settings
     std::string tls_certfile;
     std::string tls_keyfile;
 
+    std::string challenge_username;
+    std::string challenge_key_file;
+    std::string challenge_key_password;
+
     bool use_tls;
 
     static auto from_stream(std::istream &in) -> Settings;